chore: Add cargo bench for shuffle writer #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
=========================================
Coverage 34.17% 34.17%
Complexity 850 850
=========================================
Files 116 116
Lines 38547 38552 +5
Branches 8523 8524 +1
=========================================
+ Hits 13172 13175 +3
- Misses 22609 22610 +1
- Partials 2766 2767 +1 ☔ View full report in Codecov by Sentry. |
viirya
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good to me. This will be useful for contributors. Thanks @andygrove
|
Thanks for the review @viirya |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* Add cargo bench for shuffle writer * add profiling guide * add sample output (cherry picked from commit f8fec7f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I would like to profile the shuffle writer code and understand if there are any opportunities for optimizing performance.
What changes are included in this PR?
How are these changes tested?